Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ee8 modules with sources generated from ee9 sources #8066

Merged
merged 24 commits into from
Jun 1, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented May 26, 2022

add some modules ee8 translated from ee9:

  • jetty-ee8-annotations
  • jetty-ee8-jaas
  • jetty-ee8-nested
  • jetty-ee8-plus
  • jetty-ee8-security
  • jetty-ee8-servlet
  • jetty-ee8-servlets
  • jetty-ee8-webapp

@olamy olamy added the Build label May 26, 2022
@olamy olamy changed the base branch from jetty-10.0.x to jetty-12.0.x May 26, 2022 11:03
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated sources are not in jetty format. Not in itself a big deal, but when I try to run test the checkstyle plugin complains and fails.
So either remove the plugin or preserve the formatting.

@olamy
Copy link
Member Author

olamy commented May 27, 2022

The generated sources are not in jetty format. Not in itself a big deal, but when I try to run test the checkstyle plugin complains and fails. So either remove the plugin or preserve the formatting.

Will be complicated for some parts to keep exact formatting.
So I will remove it. Sorry I was using a clean install so checkstyle do not complain same as Jenkins as checkstyle is executed before source generation.

@olamy
Copy link
Member Author

olamy commented May 27, 2022

@gregw still some issues for now with -config.jar so just use mvn test

@olamy olamy force-pushed the jetty-12.0.x-ee8 branch 2 times, most recently from 0290987 to 740c465 Compare May 30, 2022 08:26
olamy added 21 commits May 31, 2022 12:18
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy olamy marked this pull request as ready for review May 31, 2022 11:33
@olamy olamy requested a review from gregw May 31, 2022 11:37
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bio readouts all in the green, looks like she is alive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants